cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Max Woghiren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2715) Use smarter buffer size for File.readAs* functions on Android
Date Mon, 18 Mar 2013 20:57:15 GMT

    [ https://issues.apache.org/jira/browse/CB-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605623#comment-13605623
] 

Max Woghiren commented on CB-2715:
----------------------------------

Pull request: https://github.com/apache/cordova-android/pull/34
                
> Use smarter buffer size for File.readAs* functions on Android
> -------------------------------------------------------------
>
>                 Key: CB-2715
>                 URL: https://issues.apache.org/jira/browse/CB-2715
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Max Woghiren
>            Priority: Minor
>
> The current code uses a ByteArrayOutputStream (growable buffer) as well as a fixed (and
too small) byte[].
> Better would be to create the byte[] once, make it the size of the "diff" variable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message