cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2661) InAppBrowser creates channels per-instance, and Channels are assumed to be unique-per-name
Date Fri, 15 Mar 2013 19:20:13 GMT

    [ https://issues.apache.org/jira/browse/CB-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603727#comment-13603727
] 

Andrew Grieve commented on CB-2661:
-----------------------------------

I was thinking that when the channels are created, they can use:

{code}
channel.onCordovaReady = channel.create('onCordovaReady')
{code}
                
> InAppBrowser creates channels per-instance, and Channels are assumed to be unique-per-name
> ------------------------------------------------------------------------------------------
>
>                 Key: CB-2661
>                 URL: https://issues.apache.org/jira/browse/CB-2661
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> The problem with this is that the channel module maintains a reference to each channel
in create():
> channel[name] = channel;
> We should just remove this behaviour from channel.js and figure out if anyone was depending
on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message