cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Jong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2634) Copy www directory script has issues with blanks in file names
Date Thu, 07 Mar 2013 22:40:12 GMT

    [ https://issues.apache.org/jira/browse/CB-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596492#comment-13596492
] 

James Jong commented on CB-2634:
--------------------------------

The script was properly enclosing the find output.  However, they were truncated in the for
loops which was causing the build to fail.

Pull request here:
https://github.com/apache/cordova-ios/pull/26
                
> Copy www directory script has issues with blanks in file names
> --------------------------------------------------------------
>
>                 Key: CB-2634
>                 URL: https://issues.apache.org/jira/browse/CB-2634
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.5.0
>         Environment: xcode 4.6
>            Reporter: Francesco Durbin
>            Assignee: James Jong
>
> this part of the "Copy www directory" script:
> {quote}
> for p in $(do_find -type f -print); do
>   subpath="${p#$SRC_DIR}"
>   if ! ln "$SRC_DIR$subpath" "$DST_DIR$subpath"; then
>     cp -a "$SRC_DIR$subpath" "$DST_DIR$subpath" || exit 3
>   fi
> done
> {quote}
> doesn't take into account that files could have blanks in the name causes the build to
crash.
> example of an error:
> {quote}
> ln: www/scripts/modernizr/media/Modernizr: No such file or directory
> cp: www/scripts/modernizr/media/Modernizr: No such file or directory
> {quote}
> where the correct file's name is: "Modernizr 2 Logo.ai"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message