cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2397) iOS: Enable non-URI startPages with small refactoring
Date Wed, 13 Mar 2013 01:50:12 GMT

    [ https://issues.apache.org/jira/browse/CB-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600713#comment-13600713
] 

Andrew Grieve commented on CB-2397:
-----------------------------------

Patches welcome :)
                
> iOS: Enable non-URI startPages with small refactoring
> -----------------------------------------------------
>
>                 Key: CB-2397
>                 URL: https://issues.apache.org/jira/browse/CB-2397
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>    Affects Versions: 2.4.0
>            Reporter: Christoph Jerolimov
>            Assignee: Shazron Abdullah
>            Priority: Minor
>
> Method {{CDVViewController viewDidLoad}} is really long and not extendable.
> At the beginning of this method the property {{startPage}} was transferred into an {{appURL}}
or an {{loadErr}}. Used at the very very end of this more than 100 lines of code.
> To allow apps to extend the {{CDVViewController}} and load other content than a simple
URL please externalize the start code to something like {{startRequest}}. No error handling,
esp. no filesystem checks are needed here.
> If it's required to show an "file not found" error it's better to implement this in the
{{webView:didFailLoadWithError:}} webview delegate callback.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message