cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Clelland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2226) FileTransfer.abort -- successfully aborting actually calls the error callback. Nothing ever gets called for the success callback.
Date Tue, 19 Mar 2013 01:47:15 GMT

    [ https://issues.apache.org/jira/browse/CB-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605936#comment-13605936
] 

Ian Clelland commented on CB-2226:
----------------------------------

That makes sense: the abort() method *should* be calling the error callback from the original
call, it looks like the the abort error callback is just overwriting the first one.

This seems consistent with the documentation at http://cordova.apache.org/docs/en/2.5.0/cordova_file_file.md.html#FileTransfer,
which  only mentions "the error callback".

I've removed those callbacks on my local fork; I'll send a pull req shortly.
                
> FileTransfer.abort -- successfully aborting actually calls the error callback. Nothing
ever gets called for the success callback.
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-2226
>                 URL: https://issues.apache.org/jira/browse/CB-2226
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Ian Clelland
>            Priority: Minor
>             Fix For: 2.6.0
>
>
> See: https://github.com/apache/cordova-ios/blob/adf226876d03723b89b4e3a9d2e9d0cfa8f2eb07/CordovaLib/Classes/CDVFileTransfer.m#L315
> The mobile spec tests only calls abort with no parameters, thus this problem was never
detected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message