cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Jong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1944) Create script on Android has to provide better error messages
Date Tue, 19 Feb 2013 19:01:14 GMT

    [ https://issues.apache.org/jira/browse/CB-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581525#comment-13581525
] 

James Jong commented on CB-1944:
--------------------------------

I'll note that there was testing on windows done by mbillau in pull request 7.  The latest
pull request 13 is the same code change.  It was rebased for a cleaner merge.  Adding comments
from the previous pull request here so the they do not get lost for the committer.

mbillau commented on 406bf6d 4 days ago
Hey James. I tested this using Windows7 x86 and every error gets generated correctly, so nice
job, I think this will help new users quite a bit. There are two suggestions I can think of:
1. It might be useful to edit the MISSING_JAVA_HOME warning to remind them to also put JAVA_HOME
in their PATH. It is possible they will set up JAVA_HOME correctly, but if they forget to
add it to the PATH, they will still get that error since the code checks the PATH for java
and javac, not JAVA_HOME. 
2. On Windows, once you change an environment variable, you need to open a new command window
to "refresh" the variable. I think we should mention this in the ERROR block so that it pops
up for all errors. Maybe something like ECHO Remember to open a new command window after editing
system variables.
Otherwise it is good to go.

jamesjong replied 4 days ago
Thanks Mike for testing the fix. I have added your two suggestions in commit c7ece5d.
                
> Create script on Android has to provide better error messages
> -------------------------------------------------------------
>
>                 Key: CB-1944
>                 URL: https://issues.apache.org/jira/browse/CB-1944
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.2.0, 2.3.0, 2.4.0
>            Reporter: Simon MacDonald
>            Assignee: Anis Kadri
>             Fix For: 2.5.0
>
>
> We moved to providing a source release that is compiled by the user via the "create"
script. In order for this to work the user is required to install and setup:
> JDK
> Ant
> Android SDK
> If any one of those packages is missing from the Windows PATH then the script fails with
a generic error message:
> Missing one of the following:
> JDK: http://java.oracle.com
> Android SDK: http://developer.android.com
> Apache ant: http://ant.apache.org
> This could be a lot better and based on the feedback on the I've seen on the mailing
list we have a lot of upset users and we could make life a lot easier for them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message