cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Brody <chris.br...@gmail.com>
Subject Re: [DISCUSS] Cordova-Windows 6.0.0
Date Fri, 09 Feb 2018 16:17:15 GMT
The tests pass on my machine if I would change <TargetPlatformVersion> to
10.0.15063.0 (I don't have the old target platform SDK installed with VS
2017 and don't intend to add it there)

On Fri, Feb 9, 2018 at 11:12 AM, Jesse <purplecabbage@gmail.com> wrote:

> Do the tests pass on your machines? If so, I think we should move forward
> with the 6.0.0 release, and write this off as a CI environment issue.
>
> On Feb 9, 2018, at 7:45 AM, Jan Piotrowski <piotrowski@gmail.com> wrote:
>
> >> I wonder if we should also consider CB-12499 to be breaking, considering
> >> that Default.rd.xml triggers the test failure on AppVeyor.
> >
> > No. "Breaking" (in context of semver) refers to changing existing
> > functionality to not work any more or work differently.
> > CB-12499 just seems "broken" right now.
> >
> > It introduces a new file and "link" to it in the Win10 project template:
> > https://github.com/apache/cordova-windows/pull/228/files And that file
> is
> > now causing issues with the test run with VS2017 on AppVeyor.
> >
> > We now just have to get the test working and pass or revert that change
> for
> > now because we can't get it to work properly.
> > (In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2
> people
> > involved in merging that functionality, maybe they can say more about it
> > over there).
> >
> >> All tests are enabled now right?
> >> Or am I mistaken?
> >
> > Yes.
> > No.
> >
> > -J
> >
> >
> > 2018-02-09 15:36 GMT+01:00 Chris Brody <chris.brody@gmail.com>:
> >
> >> I wonder if we should also consider CB-12499 to be breaking, considering
> >> that Default.rd.xml triggers the test failure on AppVeyor.
> >>
> >> All tests are enabled now right? Or am I mistaken?
> >>
> >> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski <piotrowski@gmail.com>
> >> wrote:
> >>
> >>> All that change existing functionality a user could depend on.
> >>>
> >>> In this case:
> >>> https://issues.apache.org/jira/browse/CB-13237
> >>> Possibly also the ones disabling the tests (which happened before that
> >> one,
> >>> otherwise this would have been caught)
> >>>
> >>> J
> >>>
> >>> 2018-02-08 17:06 GMT+01:00 Chris Brody <chris.brody@gmail.com>:
> >>>
> >>>> Can someone explain exactly which changes in the master branch should
> >> be
> >>>> considered "breaking"?
> >>>>
> >>>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message