cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: [DISCUSS] cordovaDependencies section in core plugins
Date Thu, 04 Jan 2018 01:44:55 GMT
I also think it should be removed.

On Jan 3, 2018 8:06 PM, "julio cesar sanchez" <jcesarmobile@gmail.com>
wrote:

> I'm +1 on removing it, we added it to avoid errors and we ended with errors
> because of it.
>
> BTW, as the plugin versions were bumped because of some platforms code
> removal in them, should we set the dependencies to only allow the install
> of latest version of that plugins in Cordova 8 as that's the one that
> removed the platforms? If not, people with older projects and the
> deprecated platforms will get that version without the platform code.
>
>
> 2018-01-03 15:07 GMT+01:00 Simon MacDonald <simon.macdonald@gmail.com>:
>
> > Going back and reading my original email I feel like I wasn't clear.
> > Specifically I was wondering if we really need something like:
> >
> > "4.0.0": {
> >     "cordova": ">100"
> > }
> >
> > in all of the plugins?
> >
> > Simon Mac Donald
> > http://simonmacdonald.com
> >
> >
> > On Tue, Jan 2, 2018 at 9:16 PM, Shazron <shazron@gmail.com> wrote:
> > > 1. Seems like a typo, let's find all the ones with typos and update to
> > > reasonable values or remove it for the plugin if its not valid.
> > > 2. I believe we need it. Some plugins have hard requirements:
> > > https://github.com/phonegap/phonegap-plugin-push/blob/
> > f6e0dccfb2a6906c37b5f89f2d2170c3ff420d97/package.json#L33-L60
> > >
> > >
> > > On Wed, Jan 3, 2018 at 2:04 AM, julio cesar sanchez <
> > jcesarmobile@gmail.com>
> > > wrote:
> > >
> > >> For reference, this is the mail discussion about adding it
> > >> https://lists.apache.org/thread.html/cee101266d23a66d57e096da0b613f
> > >> edd6e5572b2a101f5a4d4062c2@%3Cdev.cordova.apache.org%3E
> > >>
> > >> 2018-01-02 18:56 GMT+01:00 Simon MacDonald <simon.macdonald@gmail.com
> >:
> > >>
> > >> > Hey all,
> > >> >
> > >> > Recently we updated most of the core plugins to new major version.
> > >> > Unfortunately we forgot to update the "cordovaDependencies" section
> in
> > >> > package.json which prevents the next major version from being
> > >> > installed.
> > >> >
> > >> > For instance we bumped cordova-plugin-camera to version 4.0.0 but
> > >> > package.json still had:
> > >> >
> > >> > "engines": {
> > >> >   "cordovaDependencies": {
> > >> >     "3.0.0": {
> > >> >        "cordova-android": ">=6.3.0"
> > >> >     },
> > >> >     "4.0.0": {
> > >> >       "cordova": ">100"
> > >> >     }
> > >> >   }
> > >> > }
> > >> >
> > >> > so that prevented anyone not running cordova CLI version greater
> than
> > >> > 100 from installing via NPM. Since we are still at cordova 8.x this
> > >> > means no one could install the new plugin releases from NPM.
> > >> >
> > >> > Thank goodness Julio was paying attention over the holiday season
> and
> > >> > was able to get the ball rolling to fix the issue and get a bunch
of
> > >> > point releases of the core plugins released so folks would not be
> > >> > stuck in the new year.
> > >> >
> > >> > My questions are:
> > >> >
> > >> > 1) How do we prevent this from happening in the future? Should we
> > >> > document that this change needs to be made?
> > >> > 2) Do we even need this section of package.json? What purpose does
> it
> > >> hold?
> > >> >
> > >> > Thanks…
> > >> >
> > >> > Simon Mac Donald
> > >> > http://simonmacdonald.com
> > >> >
> > >> > ------------------------------------------------------------
> ---------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >> >
> > >> >
> > >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message