cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akdor1154 <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #601: CB-13485: Test with Node8
Date Mon, 23 Oct 2017 23:59:32 GMT
GitHub user akdor1154 opened a pull request:

    https://github.com/apache/cordova-lib/pull/601

    CB-13485: Test with Node8

    ### What does this PR do?
    Enables testing on Node 8 with Travis, and fixes the failing tests (no behaviour changes
seem necessary).
    
    ### What testing has been done on this change?
    `npm test`
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akdor1154/cordova-lib node8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #601
    
----
commit 8e38e274cdd140717766fc43a4b28934f4106e64
Author: Jarrad Whitaker <jwhitaker@officeworks.com.au>
Date:   2017-10-23T23:38:55Z

    Test Node 8 with Travis

commit 0a704ab17d420273d95c6efeeee3cc7b7774d6f3
Author: Jarrad Whitaker <jwhitaker@officeworks.com.au>
Date:   2017-10-23T23:51:26Z

    fix error test on Node 8

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message