cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From giuseppelt <...@git.apache.org>
Subject [GitHub] cordova-osx pull request #43: CB-13424: "cordova plugin add/remove" writes c...
Date Tue, 17 Oct 2017 11:15:16 GMT
Github user giuseppelt commented on a diff in the pull request:

    https://github.com/apache/cordova-osx/pull/43#discussion_r145098266
  
    --- Diff: bin/templates/scripts/cordova/Api.js ---
    @@ -199,8 +201,8 @@ Api.prototype.addPlugin = function (plugin, installOptions) {
      *   CordovaError instance.
      */
     Api.prototype.removePlugin = function (plugin, uninstallOptions) {
    -    var Plugman = require('./lib/plugman/Plugman');
    -    return Plugman.get(this.locations, this.events).removePlugin(plugin, uninstallOptions);
    +    var xcodeproj = projectFile.parse(this.locations);
    +    return PluginManager.get(self.platform, self.locations, xcodeproj).removePlugin(plugin,
uninstallOptions)
    --- End diff --
    
    `self` is undefined here
    replace with `this`



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message