cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-cli pull request #287: CB-13303 : added noprod/production as an opti...
Date Tue, 03 Oct 2017 21:33:56 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/287#discussion_r142529980
  
    --- Diff: src/cli.js ---
    @@ -465,6 +473,14 @@ function cli (inputArgs) {
                 // User explicitly did not pass in searchpath
                 args.searchpath = conf.get('searchpath');
             }
    +        if (args.production === undefined) {
    +            // User explicitly did not pass in noprod
    +            args.production = conf.get('production');
    +        }
    +        if (args.noprod === undefined) {
    --- End diff --
    
    lets not offer `noprod` in config. Just `args.production`. We only need noprod like you
have in line 454. Used to figure out of args.production is true or false. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message