Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2BE4200D12 for ; Sat, 23 Sep 2017 00:07:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D181D1609E5; Fri, 22 Sep 2017 22:07:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C7F9E1609D0 for ; Sat, 23 Sep 2017 00:07:02 +0200 (CEST) Received: (qmail 70862 invoked by uid 500); 22 Sep 2017 22:07:01 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 70841 invoked by uid 99); 22 Sep 2017 22:07:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2017 22:07:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EAA1A1A03A6 for ; Fri, 22 Sep 2017 22:07:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.901 X-Spam-Level: X-Spam-Status: No, score=-0.901 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ir_-fD1XQG4d for ; Fri, 22 Sep 2017 22:06:57 +0000 (UTC) Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 32ABC5FBEA for ; Fri, 22 Sep 2017 22:06:57 +0000 (UTC) Received: by mail-wr0-f173.google.com with SMTP id v109so1836960wrc.1 for ; Fri, 22 Sep 2017 15:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=cR/HbJNorhhC06GrsYb+JLQL7x5lA6erAkmjK0T0CyM=; b=KTBnrSEo7MaVYSpeO7ZdVhHJ22yU0gpTK5s2iTY2GgqfXMIdyM2QxYNOzQw+xxocMh rD4Q+UJLb/weDKmXrHfhqX+Mdmh3YXRLXeasPOHyEq0Ggp5WasmnWclsw2/nVhMwmokF ZP+X1IUX0lW17gG392y7SmLJj4EMW6gpANW1nqY3Vf/4lvE2NtYkqqP7Xa7URLukRJpy WePFaehg6kReCiy/AiSbXhPcLqfQ8R0wNED6qxbwso/L1I9e/FAocgM39mliQL7pdXUP 3mqtCRr8v7pTBcSmWlN0UQc7BNJdEGr8sMM/wpjqpzLEgjcGfVqfiqSjTp0U6I4BV3Ti Yj/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=cR/HbJNorhhC06GrsYb+JLQL7x5lA6erAkmjK0T0CyM=; b=G1GWw0SvvBv5nEk08AQfCNS+wLQLOUgKMgOndkCcbxqaude0wF3yBGx/l7zVWmTT03 FLf4rB1bpB5AIZ9Gi6AyVvPhRTBYTcZil62EDKV/ZndSebZtMqS4nXtCD6LQcZ0FzlTj Az1zZFRuJBuPPL2/8HmkoysmbfpG0N9DSxMZ+7nME8/weKUMfja0qFJxo24H1MYTGtB9 iWl7Lzlr8QP2gKt6gynpUm65mpLPFvfavi6XF0Ka15vduoBKmBnm7kfja7Eqqg/bC6xE QRHhrZbJ6Wv9X1XtR4O1xb/IswalVGXZ1RGti/yx3JHd4QMqg8KSmtJXBG2RLC6EgP9z D0GQ== X-Gm-Message-State: AHPjjUiKMwsAV4o7nxOzY+q21odd4fN9+YVRwAGmFgElK7Vvf0u1MYOL a+vWAgWoGGmEsJDj6UpwNutNP/xG+J0n5bhzt7dI X-Google-Smtp-Source: AOwi7QDgbgwV//LDfvfXLxyvCuyP6FCcHTNclAYqOkq8xHXcs5EWlmMri8krtRTYMgJhetOJWlbIit4PAEVgOUEMgHs= X-Received: by 10.223.199.196 with SMTP id y4mr390123wrg.181.1506118016398; Fri, 22 Sep 2017 15:06:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.211.194 with HTTP; Fri, 22 Sep 2017 15:06:55 -0700 (PDT) In-Reply-To: References: From: julio cesar sanchez Date: Sat, 23 Sep 2017 00:06:55 +0200 Message-ID: Subject: Re: [DISCUSS] Plugin release To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary="089e082424f45b7bd10559ce6dc7" archived-at: Fri, 22 Sep 2017 22:07:04 -0000 --089e082424f45b7bd10559ce6dc7 Content-Type: text/plain; charset="UTF-8" Yes, it's documented in coho https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md 2017-09-23 0:04 GMT+02:00 Simon MacDonald : > Yeah, we should be doing another plugins release soon. We have: > > cordova-plugin-status-bar > cordova-plugin-file-transfer > > Needing releases. > > Steve, is the release process documented anywhere so you don't have to be > the person who runs it each and every time? > > > Simon Mac Donald > http://simonmacdonald.com > > On Fri, Sep 22, 2017 at 6:00 PM, julio cesar sanchez < > jcesarmobile@gmail.com > > wrote: > > > For next release I want cordova-plugin-statusbar as I fixed it to work > > properly on iPhone X > > > > 2017-09-22 21:27 GMT+02:00 Steven Gill : > > > > > Please review the blog post for the release > > > > > > https://github.com/apache/cordova-docs/pull/734 > > > > > > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill > > > wrote: > > > > > > > Yeah I only released the plugins that people mentioned in this thread > > to > > > > release. I can fire up another plugins release next week. What > plugins > > do > > > > people want reviewed/released? > > > > > > > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald < > > > > simon.macdonald@gmail.com> wrote: > > > > > > > >> Just realized that cordova-plugin-file-transfer was never bumped. It > > > >> includes an important fix for apps. Without it new apps may be > > rejected > > > >> from the Play Store. > > > >> > > > >> > > > >> Simon Mac Donald > > > >> http://simonmacdonald.com > > > >> > > > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill < > stevengill97@gmail.com> > > > >> wrote: > > > >> > > > >> > the ios release blog post tells users about the console plugin. > > > >> > http://cordova.apache.org/announcements/2017/09/08/ios- > release.html > > > >> > > > > >> > I'll make sure to highlight these changes in the plugins release > > blog > > > >> post. > > > >> > > > > >> > Starting a new vote with console + compat only having minor bumps > > > >> > > > > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez < > > > >> > jcesarmobile@gmail.com > > > >> > > wrote: > > > >> > > > > >> > > There has been already a few people asking about the duplicate > > > >> symbols on > > > >> > > slack > > > >> > > > > > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald < > > > simon.macdonald@gmail.com > > > >> >: > > > >> > > > > > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console > > should > > > >> > receive > > > >> > > > minor version bumps. Neither breaks backwards compatibility > so I > > > >> don't > > > >> > > feel > > > >> > > > like a major version bump is warranted. > > > >> > > > > > > >> > > > As well all of our core plugins that depend on > > > cordova-plugin-compat > > > >> > use > > > >> > > > the ^1.x in their semver so they would pull in the earlier > > version > > > >> of > > > >> > the > > > >> > > > compat plugin and in combination with the upcoming > > cordova-android > > > >> > 6.3.0 > > > >> > > > pretty much all apps will fail to build. > > > >> > > > > > > >> > > > When it comes to cordova-plugin-console we should also err on > > the > > > >> side > > > >> > of > > > >> > > > caution when it comes to the version number bump. I spent some > > > time > > > >> > this > > > >> > > > morning debugging an internal app that was using cordova-ios > > 4.5.0 > > > >> and > > > >> > > > cordova-plugin-console. It was failing to build because of > > > duplicate > > > >> > > code. > > > >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release > > > before > > > >> > > > cordova-ios 4.5.0 the problem would not have existed. > > > >> > > > > > > >> > > > I think we need to be ready to start answering that question > as > > to > > > >> why > > > >> > > apps > > > >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post > > is > > > in > > > >> > > order? > > > >> > > > > > > >> > > > My recommendations is to restart this vote thread with the > four > > > >> plugins > > > >> > > but > > > >> > > > tag their versions as cordova-plugin-compat@1.2.0, > > > >> > > > cordova-plugin-console@1.1.0. The device motion and device > > > >> orientation > > > >> > > > plugins can have any version number we want as they will not > run > > > >> into > > > >> > the > > > >> > > > above problems. > > > >> > > > > > > >> > > > > > > >> > > > Simon Mac Donald > > > >> > > > http://simonmacdonald.com > > > >> > > > > > > >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill < > > > >> stevengill97@gmail.com> > > > >> > > > wrote: > > > >> > > > > > > >> > > > > Plugin vote is going to fail it seems due to the issue simon > > > >> found. > > > >> > > > > > > > >> > > > > Simons message: > > > >> > > > > "Failed > > > >> > > > > * Added cordova-plugin-camera to a project with > > cordova-android > > > >> 6.3.0 > > > >> > > > which > > > >> > > > > depends on cordova-plugin-compat and the build fails. > > > >> > > > > > > > >> > > > > The reason the build fails is that all of the cordova > plugins > > > that > > > >> > > depend > > > >> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or > > > ^1.1.0. > > > >> > > Since > > > >> > > > > compat was bumped to 2.0.0 when you install > > > cordova-plugin-camera > > > >> on > > > >> > > your > > > >> > > > > cordova-android 6.3.0 project it fails the semver and it > pulls > > > in > > > >> the > > > >> > > > 1.1.0 > > > >> > > > > version. Now both compat and cordova-android deliver the > same > > > >> classes > > > >> > > and > > > >> > > > > the build fails." > > > >> > > > > > > > >> > > > > I actually have 1.2.0 version of the plugin already tagged > > from > > > >> when > > > >> > I > > > >> > > > ran > > > >> > > > > the plugin process on Monday. It is identical to the 2.0.0 > > > version > > > >> > that > > > >> > > > is > > > >> > > > > being voted on. We can either stop the current vote thread > and > > > >> start > > > >> > a > > > >> > > > new > > > >> > > > > one with 1.2.0 instead of 2.0.0, or we could continue the > > > current > > > >> > vote > > > >> > > > > thread and start a new one just for compat@1.2.0. If we go > > with > > > >> > option > > > >> > > > 2, > > > >> > > > > we can release both 1.2.0 and 2.0.0. > > > >> > > > > > > > >> > > > > This is a good point to remember in the future. Deprecation > > > >> should be > > > >> > > > minor > > > >> > > > > not major bumps. > > > >> > > > > > > > >> > > > > > > > >> > > > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron < > shazron@gmail.com> > > > >> wrote: > > > >> > > > > > > > >> > > > > > Created PR for CB-13170 cordova-plugin-console > > > >> > > > > > https://github.com/apache/cordova-plugin-console/pull/25 > > > >> > > > > > > > > >> > > > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald < > > > >> > > > > > simon.macdonald@gmail.com> > > > >> > > > > > wrote: > > > >> > > > > > > > > >> > > > > > > Both of: > > > >> > > > > > > > > > >> > > > > > > cordova-plugin-device-motion > > > >> > > > > > > cordova-plugin-device-orientation > > > >> > > > > > > > > > >> > > > > > > should get their deprecation PR's merge and also > released. > > > >> > > > > > > > > > >> > > > > > > Simon Mac Donald > > > >> > > > > > > http://simonmacdonald.com > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron < > > shazron@gmail.com > > > > > > > >> > > wrote: > > > >> > > > > > > > +1 on console. No PRs for that yet though so it's not > > > ready. > > > >> > > > > > > > > > > >> > > > > > > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill < > > > >> > > > stevengill97@gmail.com > > > >> > > > > > > > > >> > > > > > > wrote: > > > >> > > > > > > > > > > >> > > > > > > >> Console should be released too since it has been > moved > > > back > > > >> > into > > > >> > > > ios > > > >> > > > > > for > > > >> > > > > > > >> next release. https://issues.apache.org/jira > > > >> /browse/CB-13170 > > > >> > > > > > > >> > > > >> > > > > > > >> On Sep 11, 2017 2:04 PM, "Jesse" < > > > purplecabbage@gmail.com> > > > >> > > wrote: > > > >> > > > > > > >> > > > >> > > > > > > >> > Android release is dependent on us releasing an > > > >> > > > > > > >> > updated cordova-plugin-compat > > > >> > > > > > > >> > > > > >> > > > > > > >> > Anyone have any reasons to not do a release? > Anything > > > >> > > > outstanding > > > >> > > > > > > >> > anyone wants to get merged in before moving ahead > > with > > > a > > > >> > > plugins > > > >> > > > > > > >> > release? Any other comments on the topic? > > > >> > > > > > > >> > > > > >> > > > > > > >> > Cheers, > > > >> > > > > > > >> > Jesse > > > >> > > > > > > >> > > > > >> > > > > > > >> > > > > >> > > > > > > >> > @purplecabbage > > > >> > > > > > > >> > risingj.com > > > >> > > > > > > >> > > > > >> > > > > > > >> > > > >> > > > > > > > > > >> > > > > > > ------------------------------ > > > ------------------------------ > > > >> > > > --------- > > > >> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@cordova. > > apache.org > > > >> > > > > > > For additional commands, e-mail: > > > dev-help@cordova.apache.org > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > > > > > > > > > --089e082424f45b7bd10559ce6dc7--