cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BrainstemStudio <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request #86: CB-13291: iOS 11 statusbar fixes
Date Sun, 17 Sep 2017 12:17:35 GMT
GitHub user BrainstemStudio opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/86

    CB-13291: iOS 11 statusbar fixes

    1. Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge
using the "safeAreaInsets" top and bottom. By default this will be set as "true" and crop
the webview below and above the safe areas
    
    2. When "StatusBarCropsWebview" is set to false. The web view will extend to the correcr
full screen on iPhone X. However, is the "StatusBarOverlaysWebView" is to false. This will
only extend the web view at the bottom edge
    
    3. If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set to false this
will extend the screen top and bottom edge.
    
    4. Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is set to false,
this now fixes the 20px bottom gap.
    
    5. Added fix for iOS 11 gap after status bar is set to hidden after showing. This now
fixes the 20px bottom gap.
    
    6. Added fix for iPad to force web view status bar to not run if app for iPhone but running
on iPad. Requirement from apple.
    
    See https://issues.apache.org/jira/browse/CB-13291 for full details
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BrainstemStudio/cordova-plugin-statusbar CB-13291

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
    
----
commit b2e83b26f12b68a5d504d2ba171d7fcb1e1d19a7
Author: BrainstemStudio <mail@brainstemstudio.com>
Date:   2017-09-17T11:31:58Z

    CB-13291: Fixes
    
    1. Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge
using the "safeAreaInsets" top and bottom. By default this will be set as "true" and crop
the webview below and above the safe areas
    
    2. When "StatusBarCropsWebview" is set to false. The web view will extend to the correcr
full screen on iPhone X. However, is the "StatusBarOverlaysWebView" is to false. This will
only extend the web view at the bottom edge
    
    3. If both StatusBarCropsWebview and “StatusBarOverlaysWebView” are set to false this
will extend the screen top and bottom edge.
    
    4. Added fix for iOS 11 gap problems. If “StatusBarOverlaysWebView” is set to false,
this now fixes the 20px bottom gap.
    
    5. Added fix for iOS 11 gap after status bar is set to hidden after showing. This now
fixes the 20px bottom gap.
    
    See https://issues.apache.org/jira/browse/CB-13291 for full details

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message