cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mhartington <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request #85: CB-13273: fix statusbar spacing w...
Date Fri, 15 Sep 2017 14:58:37 GMT
GitHub user mhartington opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/85

    CB-13273: fix statusbar spacing with new iphoneX

    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds additional check for iOS11/iPhone X and the new statusbar size
    
    ### What testing has been done on this change?
    Manual testing on devices and simulators.
    
    
    Note: I messed on the commit message format, tagged the wrong jira issue.
    But there is an issue for this.
    https://issues.apache.org/jira/browse/CB-13273
    
    ### Checklist
    - [ x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mhartington/cordova-plugin-statusbar CB-12886cordova-plugin-statusbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit f4dbcc2d61c01c2766afdc5e40d1c47226a04f5d
Author: mhartington <mikehartington@gmail.com>
Date:   2017-09-15T13:50:42Z

    CB-12886: fix statusbar spacing with new iphoneX

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message