cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mhartington <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...
Date Thu, 21 Sep 2017 13:41:20 GMT
Github user mhartington commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/85
  
    This pr does not address everything. In order to have full iPhoneX support you need the
following
    
    
    1) `viewport-fit=cover` added to your meta tag, this will tell the webview to use the
full screen real estate 
    2) A launch storyboard image for your splashscreen. This is a single 2732x2732 image that
will be cropped to fix different screen sizes. An example project can be found here.
    
    https://github.com/kerrishotts/lsb-example-simple
    
    
    What this PR _DOES_ is address a sizing issue for the statusbar plugin. Since it was hardcoded
to 20px, it would create a small gap when you used viewport-fit and the storyboard image.
    
    ![simulator screen shot - iphone x - 2017-09-13 at 16 53 55](https://user-images.githubusercontent.com/2835826/30698716-be64293a-9eb0-11e7-944d-79f434f247f5.png)
    
    
    But applying this fix, along with the others, you can remove that gap.
    ![simulator screen shot - iphone x - 2017-09-18 at 12 42 54](https://user-images.githubusercontent.com/2835826/30698788-fa3da8be-9eb0-11e7-9d44-21edc2689478.png)



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message