cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From varunkumarm <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #99: inAppBrowser custom applicatio...
Date Wed, 20 Sep 2017 19:59:22 GMT
Github user varunkumarm commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r140076603
  
    --- Diff: src/ios/CDVInAppBrowser.m ---
    @@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *) toolbarPosition
     
     - (void)viewDidLoad
     {
    +    CGRect frame = [UIApplication sharedApplication].statusBarFrame;
    +    UIToolbar* bgToolbar = [[UIToolbar alloc] initWithFrame:frame];
    +    bgToolbar.barStyle = UIBarStyleDefault;
    +    bgToolbar.tintColor = [UIColor whiteColor];
    +    bgToolbar.barTintColor = [UIColor whiteColor];
    +//    [[UIBarItem appearance] setTitleTextAttributes:@{UITextAttributeTextColor : [UIColor
whiteColor]}];
    +
    +
    +    [self.view addSubview:bgToolbar];
    +    
    --- End diff --
    
    @steinwelberg Can you please create the new merge request to get the essential part in?
Clearly it looks like the extra code is causing the delay. It really helps to have the changes
in the official branch than to fork and use. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message