cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BrainstemStudio <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes
Date Sun, 17 Sep 2017 14:15:30 GMT
Github user BrainstemStudio commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/86
  
    @mhartington You are correct. The viewport-fit=cover makes doe fix the problem without
the need to add the new property. I am going to revise the issue and submit.
    
    I see you have already submitted a fix for this which does work when using viewport-fit=cover.
I think it would be best for me to remove my pull request and rather let yours make the change.
    
    I would however like to suggest you add #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000
    where you use iOS 11 safearea, so errors can be avoided in previous version of xcode.
    
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message