Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: janpio <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-207-cordova-plugin-file@git.apache.org>
In-Reply-To: <git-pr-207-cordova-plugin-file@git.apache.org>
Subject: [GitHub] cordova-plugin-file pull request #207: CB-12930: (windows) Fix getDirectory ...
Content-Type: text/plain
Message-Id: <20170830173804.88A9FDFF9F@git1-us-west.apache.org>
Date: Wed, 30 Aug 2017 17:38:03 +0000 (UTC)
archived-at: Wed, 30 Aug 2017 17:38:08 -0000

Github user janpio commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136139240
  
    --- Diff: src/windows/FileProxy.js ---
    @@ -751,7 +751,13 @@ module.exports = {
             if (!fs || !validName(path)){
                 fail(FileError.ENCODING_ERR);
                 return;
    -        }           
    +        }
    +	    
    +        //check trailing "/"
    --- End diff --
    
    this actually removes a trailing slash, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org