cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...
Date Thu, 24 Aug 2017 18:35:52 GMT
GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/590

    CB-13145: Create playservices version preference in config.xml	

    Still need to add in tests
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    CB-13145: Create playservices version preference in config.xml
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib CB-13145-Steve

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #590
    
----
commit 315e6a80b95a425a07a0a32e53e24ce10e1ef89c
Author: Steve Gill <stevengill97@gmail.com>
Date:   2017-08-23T04:39:24Z

    CB-13145: pass full options to plugman uninstall

commit faa48e255fc02dd42f2bcc7eaa43f816967305cb
Author: Audrey So <audreyso@apache.org>
Date:   2017-08-23T20:27:45Z

    CB-13145 : added variable-merge.js to deal with plugin.xml variables for uninstall

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message