cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From denisx304 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #238: added cookies support for And...
Date Mon, 21 Aug 2017 16:54:48 GMT
GitHub user denisx304 opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/238

    added cookies support for Android

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Allows the `cordova.InAppBrowser.open()` function to receive another parameter, `cookies`,
an object described like `name: value`. It sets then those cookies through Android native
code.
    
    ### What testing has been done on this change?
    `cordova.InAppBrowser.open(page, "_self", null, { "cookieName": "cookieValue" });`
    The cookies were verified on the server-side.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/denisx304/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
    
----
commit 9a6f4c4dc5164073ac183eba2954e732de92519b
Author: Denis Visan <denis.visan@inomedica.ro>
Date:   2017-08-21T16:40:04Z

    added cookies support for Android

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message