cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adirel <>
Subject [GitHub] cordova-plugin-inappbrowser pull request #235: Download permissions
Date Wed, 02 Aug 2017 13:22:38 GMT
GitHub user adirel opened a pull request:

    Download permissions

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    ### What testing has been done on this change?
    ### Checklist
    - [ ] [Reported an issue]( in the JIRA
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull download-permissions

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
commit 4063179c35bbd6c4bd1f3deaef005fd2c95fe36b
Author: Gorebar <>
Date:   2016-12-12T11:49:19Z

    (Android) Implement Download Files from URL on Android WebView.

commit 45214911cbeb3268f98e0a64081ec80732829659
Author: Gorebar <>
Date:   2016-12-12T11:57:28Z

    Change Toast.

commit 358b6804b2bd96d900daa0f6cc964169205ae400
Author: Gorebar <>
Date:   2016-12-12T12:49:51Z

    Add imports

commit 162a81eb86b15ecfaea612971c89a87e025df534
Author: Mèir Noordermeer <>
Date:   2017-03-20T11:47:16Z

    Merge branch 'master' of

commit c56232f31e520f9e9ebedb699b7fa0ad35e23000
Author: Mèir Noordermeer <>
Date:   2017-03-20T15:03:35Z

    Catch errors when user has not given storage permissions on Android

commit 7b6700ab2344b1321045403db2e85bda086c2792
Author: Mèir Noordermeer <>
Date:   2017-03-20T15:51:15Z

    Add isStoragePermissionGranted to DownloadListener and catch DownloadManager errors

commit f0cc7c4ee7473fbda29cf9a51db362ff7380e0cf
Author: Jonas Oliveira <>
Date:   2017-04-14T15:07:41Z

    External Storage permissions to AndroidManifest.xml
    Without this the plugin cannot ask for user permissions

commit aaaaa72880146f4c74d51d1379baef501e935ec5
Author: Jonas Oliveira <>
Date:   2017-04-14T15:15:23Z

    Download file immediately after user authorize
    Currently the user needs to click again do download after he authorizes
    file privilegies, so I create a new class to handle the download code,
    saving to memory (via class proprieties) the download url and other info
    and handling the callback "onRequestPermissionResult"
    I also have changed the requester to "cordova.requestPermission", maybe
    this has compatibility problems with older versions of cordova or

commit 4ea9e4f747d79cd6a97e49f5801b9177465bd3ab
Author: Jonas Oliveira <>
Date:   2017-04-14T16:05:09Z

    Change download folder to system default, instead of cache


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message