cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janpio <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #234: [WIP] CB-12975: (docs) Resort...
Date Tue, 01 Aug 2017 14:38:31 GMT
GitHub user janpio opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/234

    [WIP] CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists

    This is a followup to #225 to test if I got it working. Do not merge yet please.
    
    
    ### Platforms affected
    n/a, only docs changes
    
    ### What does this PR do?
    Resort and reword cordova.InAppBrowser.open `options` lists for better developer experience.
More reasoning at https://issues.apache.org/jira/browse/CB-12975
    
    ### What testing has been done on this change?
    n/a
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - n/a Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/janpio/cordova-plugin-inappbrowser patch-1b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #234
    
----
commit 9102757ce1b97ea14ae2c59ef78a44422fe4a1bf
Author: Jan Piotrowski <piotrowski+github@gmail.com>
Date:   2017-07-01T00:41:04Z

    CB-12975 (docs) Resort and reword cordova.InAppBrowser.open `options` lists
    
     for better developer experience

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message