cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From salbahra <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #216: CB-13208: (windows) Fix `readAsBinary...
Date Wed, 23 Aug 2017 18:06:14 GMT
GitHub user salbahra opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/216

    CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range

    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Change `readAsBinaryString` on `FileReader` for Windows to use a stream which seeks to
the start position and only reads until the requested end instead of reading the entire file
to a buffer then slicing the requested fragment.
    
    ### What testing has been done on this change?
    Plugin change has been tested on Windows as that's the only platform affected.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Mimeo/cordova-plugin-file master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit 6da561fe7610fa8e4751d1d867a16af75c64019a
Author: Samer Albahra <salbahra@gmail.com>
Date:   2017-08-23T18:03:01Z

    Change `readAsBinaryString` on Windows to use a stream

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message