cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JiaLiPassion <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #215: CB-13179:(all) invoke onEvent listene...
Date Tue, 15 Aug 2017 13:57:51 GMT
GitHub user JiaLiPassion opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/215

    CB-13179:(all) invoke onEvent listener with _realReader as applyThis

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android,ios,Browser
    ### What does this PR do?
    FileReader.onEvent such as FileReader.onload should call with `this._realReader`
    
    ### What testing has been done on this change?
    Test with ios Application.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    
    Fix CB-13179, FileReader should invoke onEvent listener with this._realReader as applyThis.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JiaLiPassion/cordova-plugin-file onevent

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #215
    
----
commit 5391ff89547e0a5bad3ee1652f31528c694e2820
Author: JiaLi.Passion <jiali.passion@gmail.com>
Date:   2017-08-15T13:22:30Z

    CB-13179:(all) invoke onEvent listener with _realReader as applyThis

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message