cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdonst <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...
Date Mon, 21 Aug 2017 16:43:58 GMT
GitHub user macdonst opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/187

    CB-12809: Google Play Blocker: Unsafe SSL TrustManager Defined

    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    It removes the `trustAllHosts` parameter from the Android FileTransfer code. Google will
start [blocking apps from the PlayStore](https://support.google.com/faqs/answer/6346016) that
include unsafe implementations of the TrustManager.
    
    ### What testing has been done on this change?
    
    I've run a number of successful manual download tests after the change where the parameters
are:
    
    ```
    download(uri, fileURL, win, fail, false, options);
    download(uri, fileURL, win, fail, true, options);
    download(uri, fileURL, win, fail, options);
    download(uri, fileURL, win, fail);
    ```
    
    I ran the automatic test coverage and before my changes 25 tests failed and 2 tests were
pending. After my changes 25 tests failed and 2 tests were pending.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/macdonst/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 751d229d0fdc9c36b63979dd66754a212a020c9a
Author: Simon MacDonald <simon.macdonald@gmail.com>
Date:   2017-08-21T15:42:25Z

    CB-12809: Google Play Blocker: Unsafe SSL TrustManager Defined

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message