cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adamhaile <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #207: CB-12930: (windows) Fix getDirectory ...
Date Wed, 30 Aug 2017 17:53:49 GMT
Github user adamhaile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136143196
  
    --- Diff: src/windows/FileProxy.js ---
    @@ -751,7 +751,13 @@ module.exports = {
             if (!fs || !validName(path)){
                 fail(FileError.ENCODING_ERR);
                 return;
    -        }           
    +        }
    +	    
    +        //check trailing "/"
    --- End diff --
    
    Correct.  I submitted a (dup) JIRA report that explains why this slash causes a failure
downstream: https://issues.apache.org/jira/browse/CB-12945 .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message