cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <>
Subject [GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...
Date Wed, 30 Aug 2017 16:34:40 GMT
Github user filmaj commented on a diff in the pull request:
    --- Diff: www/FileTransfer.js ---
    @@ -163,7 +162,7 @@ FileTransfer.prototype.upload = function(filePath, server, successCallback,
    -    exec(win, fail, 'FileTransfer', 'upload', [filePath, server, fileKey, fileName, mimeType,
params, trustAllHosts, chunkedMode, headers, this._id, httpMethod]);
    +    exec(win, fail, 'FileTransfer', 'upload', [filePath, server, fileKey, fileName, mimeType,
params, false, chunkedMode, headers, this._id, httpMethod]);
    --- End diff --
    Do we need to keep the no-longer-used `trustAllHosts` parameter in the exec invocation?
Also applies to the `download` method.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message