cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #42: CB-13205: Dynamic swipe ba...
Date Tue, 22 Aug 2017 22:15:00 GMT
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42#discussion_r134615278
  
    --- Diff: src/www/ios/ios-wkwebview.js ---
    @@ -0,0 +1,9 @@
    +var exec = require('cordova/exec');
    +
    +const WkWebKit = {
    --- End diff --
    
    I wouldn't use ES6 `const` here, since ES6 is only supported in iOS 10 webviews.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message