cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #581: CB-12361 : added plugin remove tests
Date Fri, 11 Aug 2017 18:56:13 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/581#discussion_r132758763
  
    --- Diff: src/cordova/plugin/remove.js ---
    @@ -68,6 +68,7 @@ function remove (projectRoot, targets, hooksRunner, opts) {
                                     // If platform does not returned anything we'll need
                                     // to trigger a prepare after all plugins installed
                                     // TODO: if didPrepare is falsy, what does that imply?
WHY are we doing this?
    +                                events.emit('verbose', 'Calling prepare.');
    --- End diff --
    
    I think you might want to remove this event. Since Prepare will only be called if `didPrepare`
is falsy. So you could get the output `calling prepare` when you actually don't call prepare


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message