cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections
Date Wed, 09 Aug 2017 19:51:33 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/284#discussion_r132287655
  
    --- Diff: doc/readme.md ---
    @@ -186,7 +186,7 @@ After building the Android and iOS projects, the Android application
will contai
     
     #### Version control
     
    -It is recommended not to check in `platforms/` and `plugins/` directories into version
control as they are considered a build artifact. Your platforms and plugins will be saved
in config.xml & package.json automatically. These platforms/plugins will be downloaded
when on the machine when `cordova prepare` is invoked.
    +It is recommended not to check in `platforms/` and `plugins/` directories into version
control as they are considered a build artifact. Your platforms and plugins will be saved
in config.xml & package.json automatically. These platforms/plugins will be downloaded
to the machine when `cordova prepare` is invoked.
    --- End diff --
    
    I think this can be further simplified to just "... will be downloaded when `cordova prepare`
is invoked."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message