cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <alsoro...@apache.org>
Subject RE: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)
Date Tue, 29 Aug 2017 11:39:35 GMT
I vote +1:

* ran coho verify-archive
* manually verified git tags
* verified versions
* created and launched a blank app
* ensured that paramedic can build and run test app: https://travis-ci.org/alsorokin/cordova-periodic-build-browser

Thanks,
Alexander Sorokin

-----Original Message-----
From: Jesse [mailto:purplecabbage@gmail.com] 
Sent: Tuesday, August 29, 2017 12:42 AM
To: dev@cordova.apache.org
Subject: Re: [VOTE] cordova-browser@5 & cordova-serve@2 (attempt 2)

I vote +1:

* ran coho audit-license-headers over the relevant repos
* ran coho check-license to ensure all dependencies have Apache-compatible licenses
* created and ran a test project successfully
* verified that the contents of
NewProject/node_modules/cordova-browser/node_modules/cordova-serve matched
serve@2.0.0
* ran verify-archive on svn posted binaries



@purplecabbage
risingj.com

On Mon, Aug 28, 2017 at 2:02 PM, Audrey So <auso@adobe.com.invalid> wrote:

> +1
>
> I did the following:
> 1. pulled the latest cordova-browser down locally 2. updated 
> cordova-browser package.json `cordova-serve` dependency to:
> https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve%232.0.0&data=02%7C01
> %7C% 7C948615d0e2cd43b210e308d4ee57ba51%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636395507937327182&sdata=2VPUwt%
> 2FdZBUaTWnzBWNZVU9KU4qz7AoF5HQ3LXVrem4%3D&reserved=0
> 3. added my local cordova-browser
> 4. ran npm test in cordova-browser (passed) 5. cordova run in sample 
> project (passed) LGTM!
>
> Sorry sent to the wrong thread before!
>
>
> — Audrey
>
>
>
>
>
>
>
> On 8/25/17, 1:59 PM, "Steven Gill" <stevengill97@gmail.com> wrote:
>
> >Please review and vote on this 5.0.0 cordova-browser Release & 2.0.0 
> >cordova-serve Release by replying to this email (and keep discussion 
> >on the DISCUSS thread)
> >
> >Release issue: https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> 13214&data=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264&sdata=
> rlbgW6sCUf2q8Dayz3wrxLUG9BzbZ6oW3w%2F%2BsbiPfbo%3D&reserved=0
> >
> >The archive has been published to
> >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-13214
> >
> >The package was published from its corresponding git tag:
> >    cordova-browser: 5.0.0 (6e9cb1f7c6)
> >    cordova-serve: 2.0.0 (4ad258947c)
> >
> >Note that you can test it out via:
> >
> >1) pull the latest cordova-browser down locally
> >2) update cordova-browser package.json `cordova-serve` dependency to:
> >   "cordova-serve": 
> >"https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-serve.git%
> 232.0.0&data=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58%
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264&sdata=
> pw3tvj8mgBlDnaezyzDtDsb%2B4PctVvubaQi4NZE2CA4%3D&reserved=0"
> >3) add your local cordova-browser
> >    cordova platform add ../cordova-browser
> >
> >
> >Upon a successful vote I will upload the archive to dist/, publish it 
> >to npm, and post the blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdoc
> s% 
> 2Frelease-voting.md&data=02%7C01%7C%7Cd98e16c9d92944d0086908d4ebfc4f58
> % 
> 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636392916282296264&sdata=
> jIOdijpnZK1%2BLql0q0rpvp5bgDECBKKXYoykij%2Bl90o%3D&reserved=0
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and 
> >subdependencies have Apache-compatible licenses
> >* Ensured continuous build was green when repo was tagged
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message