cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From seeday <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request #91: Avoid concurrent modification o...
Date Mon, 03 Jul 2017 15:14:37 GMT
GitHub user seeday opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/91

    Avoid concurrent modification on callbacks list.

    Had been getting fast enumeration concurrent modification exceptions from what seems to
be a race condition. Enumeration is slightly smarter when looping backwards.
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes a fast enumeration crash
    
    ### What testing has been done on this change?
    Not quite sure how to run the testing suite, but it seems to work
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/seeday/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit 80bbe9ce885a9b2b8796abedd1b6b66381bb3bb0
Author: Chris Day <chrisday0001@gmail.com>
Date:   2017-06-13T17:45:43Z

    Avoid concurrent modification on callbacks list.
    
    Doesn't quite prevent it, but should be way better.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message