cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-device pull request #69: CB-13113 (browser) device.isVirtual ...
Date Wed, 26 Jul 2017 07:54:38 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-device/pull/69

    CB-13113 (browser) device.isVirtual is always false

    ### Platforms affected
    Browser
    
    ### What does this PR do?
    Introduces device.isVirtual to browser platform and makes it always equal `false`
    
    ### What testing has been done on this change?
    an automated test run on browser platform
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-device CB-13113

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
    
----
commit a886200d3f9a56a4de21090effca050c94613a2b
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2017-07-26T07:49:05Z

    CB-13113 (browser) device.isVirtual is always false

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message