cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From igormartsekha <>
Subject [GitHub] cordova-ios pull request #326: CB-12940: [IOS] Use deployment-target from co...
Date Wed, 12 Jul 2017 10:27:46 GMT
GitHub user igormartsekha opened a pull request:

    CB-12940: [IOS] Use deployment-target from config.xml for platform ve…

    …rsion in Podfile
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    It's generate Podfile using `deployment-target` option from config.xml
    ### What testing has been done on this change?
    I runed test but it failed, because API.js need valid path to config.xml file. So I changed
test, and set up valid path.
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #326
commit 2997480a21f82198232dfa061f9a42c186996ed2
Author: Igor Martsekha <>
Date:   2017-07-12T10:11:57Z

    CB-12940: [IOS] Use deployment-target from config.xml for platform version in Podfile


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message