cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...
Date Fri, 14 Jul 2017 12:29:33 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-windows/pull/237

    Cb 12636 Fix check_reqs to properly find VS 2017

    ### Platforms affected
    this one!
    
    ### What does this PR do?
    Teaches `cordova-windows` to properly recognize VS 2017 installation in the system.
    
    ### What testing has been done on this change?
    `cordova requirements` on Windows 10 / Windows 8.1 with only VS 2017, as well as with
other VS versions.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-windows CB-12636

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #237
    
----
commit c768bfee3d00d2ac2cdef0592426c7ebc2688d1c
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2017-07-13T08:47:07Z

    CB-12636 Fix check_reqs to properly find VS 2017

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message