cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-screen-orientation pull request #21: CB-12994: (android, blac...
Date Fri, 07 Jul 2017 06:12:08 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/21

    CB-12994: (android, blackberry) add es6-promise-plugin from npm

    this closes #15
    
    ### Platforms affected
    android, blackberry
    
    ### What does this PR do?
    https://issues.apache.org/jira/browse/CB-12994
    Changes the plugin to not install es6-promise-plugin dependency from git, but instead
install it from npm.
    
    ### What testing has been done on this change?
    Travis and AppVeyor is going to do all the testing
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-screen-orientation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit e6ccbc4ff56d24afc755032d711d6db2ae59ca0f
Author: Maxime Bertonnier <m.bertonnier@gmail.com>
Date:   2017-05-12T15:57:25Z

    CB-12994: (android, blackberry) add es6-promise-plugin from npm
    
    this closes #15

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message