cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SharUpOff <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #130: CB-13094: (android) Don't sho...
Date Mon, 24 Jul 2017 12:59:49 GMT
GitHub user SharUpOff opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/130

    CB-13094: (android) Don't show splash when activity being finished

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    - android
    
    ### What does this PR do?
    - Prevent to show the splash dialog if the activity is in the process of finishing referenced
to ([android docs](https://developer.android.com/reference/android/app/Activity.html#isFinishing()))
    
    
    ### What testing has been done on this change?
    - build and runtime is ok 
    - I think there are not need special tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SharUpOff/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit e5c6772f177a58c663efd3dbb8dbbc03ff9b463e
Author: Andrey Sharapov <andrey@scat.su>
Date:   2017-07-24T12:36:34Z

    CB-13094: (android) Don't show splash when activity being finished

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message