cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-android pull request #397: CB-13031: Fix bug with case-sensitivity o...
Date Mon, 24 Jul 2017 17:04:42 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/397#discussion_r129094172
  
    --- Diff: bin/templates/cordova/lib/prepare.js ---
    @@ -214,7 +215,11 @@ function updateProjectAccordingTo (platformConfig, locations) {
         shell.sed(/package [\w\.]*;/, 'package ' + pkg + ';', java_files[0]).to(destFile);
         events.emit('verbose', 'Wrote out Android package name "' + pkg + '" to ' + destFile);
     
    -    if (orig_pkg !== pkg) {
    +    var removeOrigPkg = checkReqs.isWindows() || checkReqs.isDarwin() ?
    +        orig_pkg.toUpperCase() !== pkg.toUpperCase() :
    +        orig_pkg !== pkg;
    --- End diff --
    
    I know the naming of these variables didn't originate from you, but while we're here,
can we also update the variable names used here? I found `orig_pkg` and `pkg` to be not very
descriptive. Maybe `manifest_id` instead of `orig_pkg`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message