cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-device issue #67: Fixes the NPM build and much more things [N...
Date Sun, 23 Jul 2017 18:56:34 GMT
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-device/pull/67
  
    I see lots of problems with this PR:
    
    1. The travis build fails, for starters.
    2. Why eliminate sauce labs testing? That is a core component of the end-to-end testing
for plugins! Without that we're flying blind.
    3. Setting cordova-paramedic as a dependency of the plugin, when it is only used for testing,
would be bad, as then all users of the plugin would be pulling in paramedic, which is purely
a testing tool.
    
    What specifically in these changes "fixes" stuff? And how do these changes support npm5
better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message