cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From russaa <...@git.apache.org>
Subject [GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...
Date Thu, 20 Jul 2017 09:36:20 GMT
Github user russaa commented on the issue:

    https://github.com/apache/cordova-android/pull/396
  
    I have to say, I like the current solution better (using `gradle` from Android Studio):
    
     1. you are not required to install something, that you may already have installed
     2. if you are building/debugging the Cordova app with Android Studio, you can be sure
that builds are same (as you are using the same version of `gradle`)
     3. users who prefer to install `gradle` separately still have this option
    
    If you want to get rid of the automatic-detection (because it may become cumbersome to
maintain) I would still like to have the option of using Android Studio's `gradle` by pointing
to its place via the env variable.   
    Its code should be fairly easy to maintain, since the user is responsible to specify the
correct path, i.e. the detection routine only needs to look into the env variable and does
not need to be adjusted to changing path structures etc. itself.  
    Although the mechanism then should maybe be changed, so that the env variable needs to
point the `gradle` directory directly, instead of the Android Studio directory (which it does
now), e.g. change the env variable to something like `GRADLE_HOME` and the path would need
to point, e.g. to the `gradle` sub-directory of the Android Studio directory.
    
    
    As an additional reason:  
    I assume the _"install `gradle` separately/as requirement"_ option also means, that you
must have `gradle` in your PATH env variable.
    
    On Windows, this is a concern for me, as the PATH variable has a maximum length -- which
I, for instance, are always about to exceed. So I try to not have paths there, if I can avoid
it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message