Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: stevengill <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-566-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-566-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...
Content-Type: text/plain
Message-Id: <20170621210538.E05F1DFB0D@git1-us-west.apache.org>
Date: Wed, 21 Jun 2017 21:05:38 +0000 (UTC)
archived-at: Wed, 21 Jun 2017 21:05:41 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/566#discussion_r123357002
  
    --- Diff: src/cordova/plugin/util.js ---
    @@ -0,0 +1,37 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +var path = require('path');
    +var PluginInfoProvider = require('cordova-common').PluginInfoProvider;
    +
    +module.exports.saveToConfigXmlOn = saveToConfigXmlOn;
    +module.exports.getInstalledPlugins = getInstalledPlugins;
    +
    +function getInstalledPlugins (projectRoot) {
    +    var pluginsDir = path.join(projectRoot, 'plugins');
    +    // TODO: This should list based off of platform.json, not directories within plugins/
    --- End diff --
    
    I agree that looking in the plugins directory is a bad way of doing this. Having a plugin in the plugins directory 
    
    By `platform.json`, do you mean each platform's json file? Example, `platforms/browser/browser.json`. This file contains installed plugins + dependent plugins. But we would have to get this info for each platform installed. This file also lives in `plugins/browser.json`. This file at least represents plugins that are actually installed.
    
    `plugins/fetch.json` also has information on plugins. 
    

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org