Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: stevengill <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-562-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-562-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...
Content-Type: text/plain
Message-Id: <20170615011615.0EFF4DFAB0@git1-us-west.apache.org>
Date: Thu, 15 Jun 2017 01:16:15 +0000 (UTC)
archived-at: Thu, 15 Jun 2017 01:16:18 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/562#discussion_r122101116
  
    --- Diff: src/cordova/platform.js ---
    @@ -1,769 +0,0 @@
    -/**
    --- End diff --
    
    to confirm, you ripped out this file into multpile smaller files. I like it. It has been replaced by addHelper.js, check.js, getPlatformDetailsFromDir.js, index.js, list.js, remove.js and save.js
    
    I see tests for addHelper. Do the other modules need new unit tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org