cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stalniy <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...
Date Mon, 05 Jun 2017 11:02:52 GMT
GitHub user stalniy opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/79

    CB-12882: (ios): adds support for permissions checks for camera capturing

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    adds support for checking camera permission and if camera was prohibited shows alert message
with information and 2 buttons: OK and Settings. The same `cordova-plugin-camera` does
    
    ### What testing has been done on this change?
    I ran all automated tests, they passed. Also did manual testing and added 2 additional
cases in manual tests for checking presence of alert when camera access was prohibited
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stalniy/cordova-plugin-media-capture fix/permissions-request

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #79
    
----
commit 13a5135e1defee4afd0fd38cd3c34d1dcec87580
Author: Sergii Stotskyi <sergii.stotskyi@concreteplatform.com>
Date:   2017-06-05T10:02:29Z

    CB-12882: (ios): adds support for permissions checks for captureVideo and captureImage
methods

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message