cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #572: CB-6143: Change plugman.emit() to events.emit...
Date Wed, 28 Jun 2017 07:36:16 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-lib/pull/572

    CB-6143: Change plugman.emit() to events.emit()

    ### Platforms affected
    all
    
    ### What does this PR do?
    https://issues.apache.org/jira/browse/CB-6143
    Changes remaining `plugman.emit()` calls to `events.emit()` for consistency and to fix
a build error when building a browserified app.
    
    ### What testing has been done on this change?
    `npm test`, built an android app, built a browserified android app
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-lib CB-6143

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #572
    
----
commit e32371e767bd43a86d0f83201b1d473891525fb4
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2017-06-28T07:28:58Z

    CB-6143: Change plugman.emit() to events.emit()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message