cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosov-nikita <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #565: Platform's spec is ignored in config.xml if p...
Date Wed, 21 Jun 2017 11:56:22 GMT
GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-lib/pull/565

    Platform's spec is ignored in config.xml if package.json doesn't contain dependency for
platform

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    all
    
    ### What does this PR do?
    Steps to reproduce with cordova@7.0.2-dev:
    1) Create app with package.json contains empty dependencies object: `"dependencies": {}`
    (e.g. it's default for Visual Studio Cordova template)
    2) Add entry into config.xml: `<engine name="windows" spec="https://github.com/apache/cordova-windows.git#4.4.x"
/>`
    3) `cordova platform add windows`
    
    So, if package.json dependencies keys don't include `windows or `cordova-windows`, we
should look for a spec in config.xml. 
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-lib fix-platform-installation-from-spec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #565
    
----
commit 2e5e18e52feab3be734d6ffc102f84baaf90ae10
Author: Nikita Matrosov <v-nimatr@microsoft.com>
Date:   2017-06-21T11:27:53Z

    Platform's spec is ignored in config.xml if package.json doesn't contain dependency for
platform

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message