cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #561: Cb 12870 - Check that all use cases are caugh...
Date Tue, 06 Jun 2017 00:39:22 GMT
GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/561

    Cb 12870 - Check that all use cases are caught in Api.js

    Not ready for review yet, still updating tests. Thanks!
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    Check that all use cases are caught in Api.js
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib CB-12870

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #561
    
----
commit 5ccbba28764faa675b65d26429e9685c76b98825
Author: Audrey So <audreyso@apache.org>
Date:   2017-05-31T17:41:22Z

    CB-12870 : catch all use cases for getPlatformApiFunc and update tests accordingly

commit f051199236e85a546236891303147a11d0b123ee
Author: Audrey So <audreyso@apache.org>
Date:   2017-06-03T00:24:32Z

    CB-12870 : checks if platformapi.createplatform func exists and throws error if api is
not compatible

commit 75c8d8b9bb4c3caecdd518de77a01ba95397aa0a
Author: Audrey So <audreyso@apache.org>
Date:   2017-06-05T18:47:11Z

    CB-12870 : added util tests to check getPlatformApiFunction

commit c8c8e626e698d8c742c40b2f7c8932aa52f880a1
Author: Audrey So <audreyso@apache.org>
Date:   2017-06-06T00:23:35Z

    CB-12870 : removed checkPlatformApiCompatible function and update tests in platforms.spec"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message