cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccorcos <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference
Date Thu, 15 Jun 2017 01:54:10 GMT
GitHub user ccorcos opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38

    Dynamic Swipe Preference

    This PR lets you dynamically change whether or not you can swipe navigation using `window.WkWebView.allowsBackForwardNavigationGestures(boolean)`
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine dynamic-swipe-pref

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 1109a1ace113579e76ad2384f966d8442ce14b4f
Author: Chet Corcos <ccorcos@gmail.com>
Date:   2017-06-15T01:04:14Z

    Dynamically set allowsBackForwardNavigationGestures

commit 0b6b29f9dee9cf326313639bf197c09c19c9dd18
Author: Chet Corcos <ccorcos@gmail.com>
Date:   2017-06-15T01:35:16Z

    Move code into proper @implementation

commit cf1cb7b82516d4103f9913868183e829eab3b912
Author: Chet Corcos <ccorcos@gmail.com>
Date:   2017-06-15T01:46:51Z

    Separate window.WkWebView js module into another file

commit 410b6cf4adc544e9d62c59e1fe5875d57bc3b2cc
Author: Chet Corcos <ccorcos@gmail.com>
Date:   2017-06-15T01:50:55Z

    Readme

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message