cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccorcos <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #37: CB-10376: (ios) Fix bug wh...
Date Fri, 09 Jun 2017 22:56:24 GMT
GitHub user ccorcos opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37

    CB-10376: (ios) Fix bug where WKWebView doesnt respect the KeyboardDisplayRequiresUserAction
setting

    ### Platforms affected
    
    - iOS
    
    ### What does this PR do?
    
    This PR does some magic to allow `.focus()` to bring up the keyboard in WKWebView. I read
about this approach in a few places and saw [this commit](https://github.com/Telerik-Verified-Plugins/WKWebView/commit/04e8296adeb61f289f9c698045c19b62d080c7e3)
in another plugin. From what I understand, its basically accessing a private method in WKWebView.
    
    ### What testing has been done on this change?
    
    Using it on my iPhone 7 and in the Simulator and it definitely works :) I'm not a native
developer so I could use some guidance getting this PR to the point where its mergeable. But
its definitely useful and absolutely necessary for [the app I'm building](www.notion.so).
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ccorcos/cordova-plugin-wkwebview-engine master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit e994874583d7e5f4ae1713643dbd8e01c60a0a03
Author: Chet Corcos <ccorcos@gmail.com>
Date:   2017-06-09T22:42:25Z

    Patch KeyboardDisplayRequiresUserAction

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message