cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-browser pull request #36: CB-12804 Fixes some simple details - manif...
Date Tue, 27 Jun 2017 01:12:04 GMT
GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-browser/pull/36

    CB-12804 Fixes some simple details - manifest.json

    
    ### Platforms affected
    browser
    
    ### What does this PR do?
    addresses issues raised with pr #32
    
    ### What testing has been done on this change?
    manual testing
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-browser CB-12804-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 7aa99f6f19ec8cf4be4136242e42d36cb6ec460b
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-06-27T01:07:20Z

    Approach cache more defensively

commit b7ac532a06f3aea72bb45d5e6b8c7c36ed48cbcd
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-06-27T01:08:21Z

    use white as default bgcolor in manifest, map unknown orientation values to 'any', address
some issues raised in #32

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message