cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giorgioshooter <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #321: CB-12937 - (iOS) added new method handleOpenU...
Date Tue, 20 Jun 2017 19:20:42 GMT
GitHub user Giorgioshooter opened a pull request:

    https://github.com/apache/cordova-ios/pull/321

    CB-12937 - (iOS) added new method handleOpenURLWithApplicationSourceAndAnno…

    …tation in CDVPlugin and new notification id CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification
which is broadcasted from CDVAppDelegate openURL method.
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    adds a new public method handleOpenURLWithApplicationSourceAndAnnotation in CDVPlugin
which contains the URL the applicationSource and annotation 
    
    ### What testing has been done on this change?
    Run test suite for cordova-ios 
    tested on an example app to make sure that the original  handleOpenURL. 
    I did not find any tests on CDVPlugin 
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Giorgioshooter/cordova-ios CB-12937-handleOpenURL-with-applicationSource-and-annotation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #321
    
----
commit f49771bfa084b1b64965ee97a3b4afbf407693c3
Author: Georgios Galatoulas <georgiosgalatoulas@gmail.com>
Date:   2017-06-20T12:35:40Z

    CB-12937 - added new method handleOpenURLWithApplicationSourceAndAnnotation in CDVPlugin
and new notification id CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification which
is broadcasted from CDVAppDelegate openURL method.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message